Fix active tab not updating when dragged to another container#115
Open
stargazing-dino wants to merge 1 commit intorerun-io:mainfrom
Open
Fix active tab not updating when dragged to another container#115stargazing-dino wants to merge 1 commit intorerun-io:mainfrom
stargazing-dino wants to merge 1 commit intorerun-io:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Getting the next active was buggy.
The logic here said to only look for a tile that is visible. But the moved tile technically is still visible if you just move it to another docking area.
Instead, we should also ask if our children contains that tile as well as being visible.
Before fix:
Screen.Recording.2026-02-03.at.9.11.50.PM.mov
After fix:
Screen.Recording.2026-02-03.at.9.11.02.PM.mov