Make duration handling of video more robust #10646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
added
🚜 refactor
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
Wumpf
force-pushed
the
andreas/video/refactor-duration-handling
branch
from
e1a2581 to
74bcc0e
Compare
Wumpf
added
the
exclude from changelog
Wumpf
force-pushed
the
andreas/video/refactor-duration-handling
branch
from
74bcc0e to
d651834
Compare
Wumpf
force-pushed
the
andreas/video/refactor-duration-handling
branch
from
d651834 to
ef5605f
Compare
emilk
requested changes
Aug 26, 2025
crates/viewer/re_viewer_context/src/cache/video_stream_cache.rs
Outdated
Show resolved
Hide resolved
crates/viewer/re_viewer_context/src/cache/video_stream_cache.rs
Outdated
Show resolved
Hide resolved
|
very nice naming suggestions, thanks! |
emilk
reviewed
Aug 26, 2025
crates/viewer/re_viewer_context/src/cache/video_stream_cache.rs
Outdated
Show resolved
Hide resolved
crates/viewer/re_viewer_context/src/cache/video_stream_cache.rs
Outdated
Show resolved
Hide resolved
emilk
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How durations are handled for our internal video meta information is a bit brittle right now.
Also, how we distinguish open-ended versus "closed" videos was quite arcane and hard to follow so far. This refactor makes all these things more explicit and a lot more stable.
(this PR was set up as part of Video leading up to 0.24 but didn't make the cut; deemed needlessly risky just before the release)