Skip to content

Conversation

Xiao-Chenguang
Copy link
Contributor

Related

What

Support customise x-axis (index) for BarChart

This draft PR include changes that enable index customization of BarChart.
The index of BarChart has to be 0-indexed continus intagers originally, while a lot of use case require a customized index as in related issues.

This PR include changes to both the BarChart data type as view system. As rerun use BarChart from egui_plot where index is supported, an extra field indexes is add to rerun.BarChart.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for opening this pull request.

Because this is your first time contributing to this repository, make sure you've read our Contributor Guide and Code of Conduct.

@grtlr
Copy link
Contributor

grtlr commented Jul 30, 2025

Thank you for your contribution! What's the status of your work, do you plan on finishing this up or is it ready for review yet?

@Xiao-Chenguang
Copy link
Contributor Author

Thank you for your contribution! What's the status of your work, do you plan on finishing this up or is it ready for review yet?

Hi grtlr, It's my first PR to rerun. So I make it a draft PR as requested. It's ready for review now except the failed RP label check.

@Xiao-Chenguang Xiao-Chenguang marked this pull request as ready for review August 1, 2025 16:09
@grtlr
Copy link
Contributor

grtlr commented Aug 5, 2025

Thank you for the clarification! We'll put it onto our review queue!

@Wumpf Wumpf changed the title Support flexiable x-axis for bars in BarChart Support flexible x-axis for bars in BarChart Aug 6, 2025
@Wumpf Wumpf self-requested a review August 6, 2025 08:26
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your contribution! I think with some iteration on naming and documentation we can take this as-is :)

Please add an additional snippet, similar to docs/snippets/all/archetypes/tensor_simple.py/cpp/rs demonstrating the new feature. Thank you!

@Wumpf Wumpf added 📺 re_viewer affects re_viewer itself include in changelog feat-plots Plots, charts, graphs, timeseries, … labels Aug 6, 2025
@Xiao-Chenguang Xiao-Chenguang requested a review from Wumpf August 10, 2025 20:08
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks all good now, thanks again!

I've updated screenshot, updated version comparision rrd and fixed up the C++ snippet. Good to merge on green ci

@Wumpf
Copy link
Member

Wumpf commented Aug 12, 2025

interesting, the image comparision test found that this actually breaks layout a bit

before:
tensor_1d

after:
tensor_1d new

@Wumpf
Copy link
Member

Wumpf commented Aug 12, 2025

@Xiao-Chenguang maybe you want to have a last look before merging given that I messed with it so much now :)

@Xiao-Chenguang
Copy link
Contributor Author

@Xiao-Chenguang maybe you want to have a last look before merging given that I messed with it so much now :)

it looks good now. let's go ahead

@Wumpf Wumpf merged commit 3dbf47d into rerun-io:main Aug 13, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat-plots Plots, charts, graphs, timeseries, … include in changelog 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants