Add TestView and write tests for Item::View in re_selection_panel
#10716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grtlr
added
🔨 testing
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
grtlr
force-pushed
the
grtlr/selection-panel-view
branch
from
9cbb674 to
758915b
Compare
Wumpf
approved these changes
Aug 11, 2025
| @@ -1322,4 +1327,156 @@ mod tests { | |||
| harness.run(); | |||
| harness.snapshot("selection_panel_component_hybrid_overwrite"); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn selection_panel_view_snapshot() { | |||
There was a problem hiding this comment.
I think I would have made those three all call the same parameterized function, but this is fine too I figure; the boilerplate isn't that crazy
|
not sure what artifact your TODO is referring too |
|
oh, I see. Weird! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This adds a
TestViewmock tore_viewport_contextthat uses the example types fromre_typeswhere appropriate. For now it does not display anything (and probably never should). Right now it's only used to test write image comparison tests for the selection panel.TODO
Clean up artifact in selection panel UI. Possibly related:merging anyways (see comments)LabelContentshould be able to have the exact same action button and behaviour asPropertyContent#6203