Implement row filtering on client side #10829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
timsaucer
added
exclude from changelog
emilk
approved these changes
Aug 11, 2025
| @@ -190,6 +191,49 @@ impl DataframeQueryTableProvider { | |||
| chunk_request, | |||
| }) | |||
| } | |||
|
|
|||
| fn column_to_selector(column: &Column) -> Option<ComponentColumnSelector> { | |||
There was a problem hiding this comment.
Nit/style: we usually prefer selector_from_column (see CODE_STYLE.md).
Mostly for consistency with matrices, but also writing it let selector = selector_from_column(column); means the names in the function title is next to the types of the input/output variables (instead of being swizzled)
| ComponentColumnSelector::from_str(column.name()).ok() | ||
| } | ||
|
|
||
| fn compute_column_is_not_null_filter( |
There was a problem hiding this comment.
This could use a docstring to explain that what this checks for, especially since the function name can be read two ways (does it return true for the filter foo == 42 since that is not a null filter?)
| ComponentColumnSelector::from_str(column.name()).ok() | ||
| } | ||
|
|
||
| fn compute_column_is_not_null_filter( |
There was a problem hiding this comment.
Maybe this would read slightly better?
Suggested change
| fn compute_column_is_not_null_filter( | |
| fn compute_column_is_neq_null_filter( |
Comment on lines
205
to
233
| match expr { | ||
| Expr::IsNotNull(inner) => { | ||
| if let Expr::Column(col) = inner.as_ref() { | ||
| return Ok(Self::column_to_selector(col)); | ||
| } | ||
| } | ||
| Expr::Not(inner) => { | ||
| if let Expr::IsNull(col_expr) = inner.as_ref() { | ||
| if let Expr::Column(col) = col_expr.as_ref() { | ||
| return Ok(Self::column_to_selector(col)); | ||
| } | ||
| } | ||
| } | ||
| Expr::BinaryExpr(binary) => { | ||
| if binary.op == Operator::NotEq { | ||
| if let (Expr::Column(col), Expr::Literal(sv)) | ||
| | (Expr::Literal(sv), Expr::Column(col)) = | ||
| (binary.left.as_ref(), binary.right.as_ref()) | ||
| { | ||
| if sv.is_null() { | ||
| return Ok(Self::column_to_selector(col)); | ||
| } | ||
| } | ||
| } | ||
| } | ||
| _ => {} | ||
| } | ||
|
|
||
| Ok(None) |
There was a problem hiding this comment.
Nit: this would read nicer with a helper function
Suggested change
| match expr { | |
| Expr::IsNotNull(inner) => { | |
| if let Expr::Column(col) = inner.as_ref() { | |
| return Ok(Self::column_to_selector(col)); | |
| } | |
| } | |
| Expr::Not(inner) => { | |
| if let Expr::IsNull(col_expr) = inner.as_ref() { | |
| if let Expr::Column(col) = col_expr.as_ref() { | |
| return Ok(Self::column_to_selector(col)); | |
| } | |
| } | |
| } | |
| Expr::BinaryExpr(binary) => { | |
| if binary.op == Operator::NotEq { | |
| if let (Expr::Column(col), Expr::Literal(sv)) | |
| | (Expr::Literal(sv), Expr::Column(col)) = | |
| (binary.left.as_ref(), binary.right.as_ref()) | |
| { | |
| if sv.is_null() { | |
| return Ok(Self::column_to_selector(col)); | |
| } | |
| } | |
| } | |
| } | |
| _ => {} | |
| } | |
| Ok(None) | |
| if is_neq_null(expr) { | |
| Ok(Self::column_to_selector(col)) | |
| } else { | |
| Ok(None) | |
| } |
That would also allow us to unit-test is_neq_null
Comment on lines
212
to
213
| if let Expr::IsNull(col_expr) = inner.as_ref() { | ||
| if let Expr::Column(col) = col_expr.as_ref() { |
Comment on lines
219
to
224
| if binary.op == Operator::NotEq { | ||
| if let (Expr::Column(col), Expr::Literal(sv)) | ||
| | (Expr::Literal(sv), Expr::Column(col)) = | ||
| (binary.left.as_ref(), binary.right.as_ref()) | ||
| { | ||
| if sv.is_null() { |
timsaucer
force-pushed
the
tsaucer/streaming_provider_filtering
branch
from
ddf569b to
f172a07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
Closes https://github.com/rerun-io/dataplatform/issues/851
What
This PR identifies when the push down filters provided to the table provider are checking for a component that is not null. If so it pushes this filter down into the chunk store query. This reduces the amount of data coming out of the cpu worker thread and passed into the rest of the datafusion engine.
These are equivalent