Skip to content

Conversation

timsaucer
Copy link
Contributor

This PR is to add the in-memory rerun server for testing of the gRPC calls in CI.

Copy link

github-actions bot commented Aug 7, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
5deb5c7 https://rerun.io/viewer/pr/10837 +nightly +main

Note: This comment is updated whenever you push a commit.

@timsaucer timsaucer force-pushed the tsaucer/move_over_rerun_server branch from 6e1adc0 to 3781909 Compare August 8, 2025 17:58
@timsaucer timsaucer added 🔨 testing testing and benchmarks exclude from changelog PRs with this won't show up in CHANGELOG.md labels Aug 11, 2025
@timsaucer timsaucer requested a review from abey79 August 11, 2025 14:59
@timsaucer timsaucer marked this pull request as ready for review August 11, 2025 16:52
Copy link
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only gave it a cursory look as it's mainly copy/paste, but looks good to me. Very excited what we can build from this, esp. testing.

Comment on lines -123 to -130
| Crate | Description |
| --------- | ------------------------------------ | ------------------------ | --- |
| rerun-cli | Rerun native CLI binary crate |
| Rerun | Rerun Rust SDK and Viewer shim crate |
| rerun_c | Rerun C SDK |
| rerun_py | Rerun Python SDK |
| re_sdk | Rerun logging SDK |
| <!-- | re_renderer_examples | Examples for re_renderer | --> |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears it predates this PR, but the markdown rendering for this table is broken. It would be great to fix it.

Image

AccountingAllocator::new(mimalloc::MiMalloc);

fn main() -> std::process::ExitCode {
// NOTE: no full-fledged telemetry, this is supposed to run as part of the OSS offering.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// NOTE: no full-fledged telemetry, this is supposed to run as part of the OSS offering.

@timsaucer timsaucer force-pushed the tsaucer/move_over_rerun_server branch from eacd529 to 5deb5c7 Compare August 12, 2025 13:35
@timsaucer timsaucer merged commit 1061dfb into main Aug 12, 2025
40 checks passed
@timsaucer timsaucer deleted the tsaucer/move_over_rerun_server branch August 12, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🔨 testing testing and benchmarks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants