Skip to content

Conversation

aedm
Copy link
Member

@aedm aedm commented Aug 8, 2025

Related

What

Adds color and line_width parameters to Pinhole camera to customize visualization.

image

TODO

  • @rerun-bot full-check passes

Copy link

github-actions bot commented Aug 8, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
e6efda1 https://rerun.io/viewer/pr/10842 +nightly +main

Note: This comment is updated whenever you push a commit.

Copy link

github-actions bot commented Aug 8, 2025

Latest documentation preview deployed successfully.

Result Commit Link
e6efda1 https://landing-oatgozlwg-rerun.vercel.app/docs

Note: This comment is updated whenever you push a commit.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for opening this pull request.

Because this is your first time contributing to this repository, make sure you've read our Contributor Guide and Code of Conduct.

@aedm aedm added include in changelog 🪵 Log & send APIs Affects the user-facing API for all languages labels Aug 13, 2025
@aedm
Copy link
Member Author

aedm commented Aug 14, 2025

@rerun-bot full-check

Copy link

Started a full build: https://github.com/rerun-io/rerun/actions/runs/16960889847

@aedm aedm changed the title Ability to change the color of the Pinhole camera frustum Customize color and line width of Pinhole camera frustum Aug 14, 2025
@aedm
Copy link
Member Author

aedm commented Aug 14, 2025

@rerun-bot full-check

Copy link

Started a full build: https://github.com/rerun-io/rerun/actions/runs/16966861820

@aedm aedm self-assigned this Aug 15, 2025
@aedm aedm requested review from Wumpf and grtlr August 15, 2025 08:20
@aedm aedm marked this pull request as ready for review August 15, 2025 08:21
Copy link
Contributor

@grtlr grtlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@grtlr
Copy link
Contributor

grtlr commented Aug 15, 2025

@rerun-bot full-check

Copy link

@grtlr grtlr added the 📺 re_viewer affects re_viewer itself label Aug 15, 2025
@aedm
Copy link
Member Author

aedm commented Aug 15, 2025

@rerun-bot full-check

Copy link

@aedm aedm merged commit e20127b into main Aug 15, 2025
87 of 90 checks passed
@aedm aedm deleted the aedm/8572-pinhole-customization branch August 15, 2025 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog 🪵 Log & send APIs Affects the user-facing API for all languages 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to change the color of the Pinhole camera frustum (currently it's always gray) Ability to style pinhole frustum
2 participants