Revert BinaryArray migration (#11039)
#11065
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
|
Latest documentation preview deployed successfully.
Note: This comment is updated whenever you push a commit. |
This was referenced Sep 2, 2025
|
To undo this PR, we just need to merge these: |
emilk
added a commit
that referenced
this pull request
Sep 2, 2025
### Related * #11065 * #11028 ### What We do not yet support migrating schemas on cloud (#11028) so we had to revert changing the datatype of `Blob` from `List<u8>` to `LargeBinary`. However, in the revert we threw away a lot of good baby with the bath water. This PR selectively cherry-pick back a bunch of things that we do want in, without actually changing any data formats. This lets us: * Get in some good stuff * Reduce merge conflicts on other PRs to main * Reduce future merge conflicts when we want to change the datatype again NOTE: everything in here has already been reviewed before ### TODO * [x] `@rerun-bot full-check`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picking from #11039)
Related
Blobas arrowBinary#10875BlobasLargeBinary#11005What
Reverts the the change from
List<u8>toBinarybecause of Rerun Cloud migration woes.Hopefully temporarily.