-
Notifications
You must be signed in to change notification settings - Fork 538
Move copy / save buttons inline with the relevant component #11181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Web viewer built successfully.
Note: This comment is updated whenever you push a commit. |
I miss some sort of tooltip for the button |
Also: clicking the copy button provides no feedback. I would expect a "Image copied to clipboard!" or something. Right now it just feels dead/broken, even though it actually works. Just a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! But we need some feedback after clicking the copy button, and ideally a tooltip too
Related
LabelContent
,PropertyContent
andSectionHeader
#11164What
This moves the copy / save buttons inline next to the component. In order to do this, I've split the blob / image / video uis into structs with a
data_ui
andinline_button
fns. TheExtraDataUi
is a wrapper for convenience.In hindsight this could have probably also been done using freestanding fns.
This also fixes a couple inconsistencies between
Image
andEncodedImage
. Both now show a histogram and both show the image format.EncodedImage:

Image:

AssetVideo:
