Skip to content

Conversation

lucasmerlin
Copy link
Member

@lucasmerlin lucasmerlin commented Sep 11, 2025

Related

What

This moves the copy / save buttons inline next to the component. In order to do this, I've split the blob / image / video uis into structs with a data_ui and inline_button fns. The ExtraDataUi is a wrapper for convenience.

In hindsight this could have probably also been done using freestanding fns.

This also fixes a couple inconsistencies between Image and EncodedImage. Both now show a histogram and both show the image format.

EncodedImage:
Screenshot 2025-09-11 at 16 14 08

Image:
Screenshot 2025-09-11 at 16 16 03

AssetVideo:
Screenshot 2025-09-11 at 16 14 46

Copy link

github-actions bot commented Sep 11, 2025

Web viewer built successfully.

Result Commit Link Manifest
905524a https://rerun.io/viewer/pr/11181 +nightly +main

Note: This comment is updated whenever you push a commit.

@lucasmerlin lucasmerlin changed the title Fix duplicate download buttons Move copy / save buttons inline with the relevant component Sep 11, 2025
@lucasmerlin lucasmerlin added the ui concerns graphical user interface label Sep 11, 2025
@emilk
Copy link
Member

emilk commented Sep 11, 2025

Screenshot 2025-09-11 at 16 31 46 I love this design

@emilk emilk self-requested a review September 11, 2025 14:32
@emilk
Copy link
Member

emilk commented Sep 11, 2025

I miss some sort of tooltip for the button

@emilk
Copy link
Member

emilk commented Sep 11, 2025

Also: clicking the copy button provides no feedback. I would expect a "Image copied to clipboard!" or something. Right now it just feels dead/broken, even though it actually works.

Just a re_log::info will do it 🤷

Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! But we need some feedback after clicking the copy button, and ideally a tooltip too

Base automatically changed from lucas/list-item-consistent-buttons to main September 12, 2025 09:16
@grtlr grtlr linked an issue Sep 12, 2025 that may be closed by this pull request
@Wumpf Wumpf self-assigned this Sep 12, 2025
@Wumpf Wumpf merged commit b9f1a66 into main Sep 12, 2025
40 checks passed
@Wumpf Wumpf deleted the lucas/fix-duplicated-blob-buttons branch September 12, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple blobs on same entity leads to ambiguous UI
3 participants