Skip to content

Conversation

jprochazk
Copy link
Member

@jprochazk jprochazk commented Sep 19, 2025

The diff is a bit confusing, so prefer reviewing the rendered page directly.

@jprochazk jprochazk added 📖 documentation Improvements or additions to documentation ⛴ release Related to shipping or publishing exclude from changelog PRs with this won't show up in CHANGELOG.md labels Sep 19, 2025
Copy link
Member

@aedm aedm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think this version is easier to follow. :)

This might be out of scope for this PR, but what I miss the most is a summary at the beginning of how it all works: which steps create which artifacts, what docs-latest is, and especially how versioning works, that seems to be somewhat confusing for multiple people.


![Image showing the Run workflow UI. It can be found at https://github.com/rerun-io/rerun/actions/workflows/release.yml](https://github.com/rerun-io/rerun/assets/1665677/6cdc8e7e-c0fc-4cf1-99cb-0749957b8328)

### 7. Wait for the workflow to finish
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### 7. Wait for the workflow to finish
### 7. Wait for both the workflows to finish

Comment on lines 145 to +147
Note: there are two separate workflows running -- the one building the release artifacts, and the one running the PR checks.
You will have to wait for the [former](https://github.com/rerun-io/rerun/actions/workflows/release.yml) in order to get a link to the artifacts.
You can mostly ignore the PR checks. You will have to wait for the [former](https://github.com/rerun-io/rerun/actions/workflows/release.yml)
in order to get a link to the artifacts.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make this section even more explicit, something like:

The Release workflow will build artifacts and run PR checks.
Additionally, it will spawn a second workflow (WHEN?) that called GitHub Release.
This workflow is responsible for creating the GitHub release draft and to publish the artifacts to it.
Make sure this workflow also finishes!.
Only after it finishes successfully should you un-draft the GitHub release.

@jprochazk
Copy link
Member Author

It turns out our crates.py publishing script does not support prepare-release-x.y.z, so it will have to be updated as well

@jprochazk
Copy link
Member Author

(I am still planning to finish this, but Azure is a higher priority right now)

@emilk emilk marked this pull request as draft September 25, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 documentation Improvements or additions to documentation exclude from changelog PRs with this won't show up in CHANGELOG.md ⛴ release Related to shipping or publishing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants