Blueprint save/load test #11395
Merged
Blueprint save/load test #11395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Web viewer built successfully.
Note: This comment is updated whenever you push a commit. |
Wumpf
approved these changes
Oct 2, 2025
Comment on lines
+76
to
+77
| // Trigger recalculation of visualizable entities and blueprint overrides. | ||
| test_context.setup_viewport_blueprint(|_ctx, _blueprint| {}); |
There was a problem hiding this comment.
oof that's the annoying thing you've mentioned on yesterday standup where App is recalculating it all the time and TestContext is not? Feels like TestContext is in the wrong here, but I figure we can't do that where test context's run method lives or something of that shape?
There was a problem hiding this comment.
Yes, it is. :(
The new App-based harness work differently, it loads the current blueprint from the store at the start of each frame. The TestContext only does that when you explicitly call this function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
What
Adds save/load/snapshot tests for blueprints.
Note: the
check_rbl_import.pycan't yet be removed as it's testing blueprint imports with a different app id, this test doesn't cover it yet, this is whereAppandTestContextdiffer somewhat.