Construct an empty struct for empty ROS2 message definitions #11488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxkitsune
added
🪳 bug
|
Web viewer built successfully.
Note: This comment is updated whenever you push a commit. |
oxkitsune
added
the
exclude from changelog
oxkitsune
changed the title
emilk
requested changes
Oct 13, 2025
|
|
||
| fn finish(&mut self) -> arrow::array::ArrayRef { | ||
| Arc::new(self.builder.finish()) | ||
| // Special case for empty structs, e.g. `std_msgs/Empty` |
There was a problem hiding this comment.
I can see from the code that we're special-casing it, but I cannot see why.
Comment the why, not the what
There was a problem hiding this comment.
This is an attempt to fix an issue when querying out these empty columns. However, it looks like it might be a datafusion issue: RR-2653.
Marking this as draft until then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
What
This treats empty messages as a special case again, and correctly constructs an empty struct.