Skip to content

Conversation

@oxkitsune
Copy link
Member

Related

What

This implements query filtering for temporal/static chunks in the OSS server.

@github-actions
Copy link

github-actions bot commented Nov 26, 2025

Web viewer built successfully.

Result Commit Link Manifest
81bdeb4 https://rerun.io/viewer/pr/11984 +nightly +main

View image diff on kitdiff.

Note: This comment is updated whenever you push a commit.

@abey79 abey79 self-requested a review November 26, 2025 10:03
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ❤️

├╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┤
00000000000000030000000000000005my_partition_id3base/yet/another/onefalse
├╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┤
00000000000000030000000000000006my_partition_id3base/yet/another/onetrue
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this actually exclude any chunks? Hard to tell without a corresponding "everything" query

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a test with no filtering at all, and it returns the same thing - so this seems broken

@emilk emilk changed the title Add static/temporal chunk query filtering to OSS server Implement chunk query filtering in OSS server Nov 28, 2025
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The time range filter seems broken

├╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┤
00000000000000030000000000000005my_partition_id3base/yet/another/onefalse
├╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┤
00000000000000030000000000000006my_partition_id3base/yet/another/onetrue
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a test with no filtering at all, and it returns the same thing - so this seems broken

├╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┤
00000000000000030000000000000005my_partition_id3base/yet/another/onefalse
├╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┤
00000000000000030000000000000006my_partition_id3base/yet/another/onetrue
Copy link
Member

@emilk emilk Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also returns all partitions, with no visible filtering

@oxkitsune
Copy link
Member Author

There seem to be some deeper issues with the API endpoint, because the tests also do not pass on redap.
I have removed the fuzzy matching/time querying and plan to add those in a separate PR instead, so we can get the temporal/static filtering merged.

@oxkitsune oxkitsune changed the title Implement chunk query filtering in OSS server Add static/temporal chunk query filtering to OSS server Dec 1, 2025
@oxkitsune oxkitsune force-pushed the gijs/oss-server-querying branch from 3f8731f to 7f59051 Compare December 2, 2025 13:55
@oxkitsune oxkitsune merged commit 64beb85 into main Dec 3, 2025
40 checks passed
@oxkitsune oxkitsune deleted the gijs/oss-server-querying branch December 3, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants