Make transform frame edit not experimental #12057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IsseW
added
ui
|
Web viewer built successfully.
View image diff on kitdiff. Note: This comment is updated whenever you push a commit. |
grtlr
approved these changes
Dec 3, 2025
Member
grtlr
left a comment
grtlr
left a comment
There was a problem hiding this comment.
That's a very nice improvement!
Only some minor comments.
emilk
reviewed
Dec 3, 2025
Wumpf
pushed a commit
that referenced
this pull request
Dec 3, 2025
### Related * Closes RR-3044 ### What Improves the frame id edit in the selection panel, and makes it not experimental. ### Preview When the frame hasn't been overridden the text is subdued. <img width="376" height="31" alt="Screenshot 2025-12-02 at 17 31 01" src="https://github.com/user-attachments/assets/51436fdd-fa99-4f09-b386-4927e4383fa9" /> When starting to edit the frame it shows suggestions <img width="376" height="107" alt="Screenshot 2025-12-02 at 17 31 13" src="https://github.com/user-attachments/assets/ec4779d0-f2a7-4863-b82c-e3b74f1a547f" /> When editing the frame it keeps showing suggestion that match what you've written so far. The text is also red if the current value doesn't match an existing frame. <img width="376" height="66" alt="Screenshot 2025-12-02 at 17 31 28" src="https://github.com/user-attachments/assets/b2101ca6-ef06-42e0-b882-9b76aa5a143f" /> When overridden it uses the default text color. <img width="376" height="31" alt="Screenshot 2025-12-02 at 17 31 48" src="https://github.com/user-attachments/assets/d46447cc-88e3-4422-9cd3-dc01bc5e63a4" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
What
Improves the frame id edit in the selection panel, and makes it not experimental.
Preview
When the frame hasn't been overridden the text is subdued.
When starting to edit the frame it shows suggestions
When editing the frame it keeps showing suggestion that match what you've written so far. The text is also red if the current value doesn't match an existing frame.
When overridden it uses the default text color.