Refactor auth state handling #12058
Open
Refactor auth state handling #12058
+92
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Web viewer built successfully.
View image diff on kitdiff. Note: This comment is updated whenever you push a commit. |
lucasmerlin
added
exclude from changelog
lucasmerlin
commented
Dec 2, 2025
Comment on lines
+65
to
+66
| // TODO: Is login hint required? | ||
| match LoginFlow::open(ui, None) { |
Member
Author
There was a problem hiding this comment.
Not sure how this should be handled. I assume the login hint will prefill the email in the browser is set? But now we should only have a email if the user is logged in, so this feels kind of useless. Did this do something before?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This adds a way to add a callback to re_auth whenever auth state changes and uses that to add a AuthContext to the GlobalContext that is set when the user is logged in