Skip to content

Fix incorrect bindings in Global #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 30, 2024
Merged

Fix incorrect bindings in Global #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de52ac8
Fix incorrect bindings in `Global`
stephanoskomnenos Dec 30, 2024
6d1826a
Update test
stephanoskomnenos Dec 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/Global.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,7 +505,6 @@ let response = await fetch(myRequest)

[Read more on MDN](https://developer.mozilla.org/docs/Web/API/Window/fetch)
*/
@send
external fetch_withRequest: (request, ~init: requestInit=?) => promise<response> = "fetch"

/**
Expand Down Expand Up @@ -567,7 +566,7 @@ Removes the event listener in target's event listener list with the same type, c
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/EventTarget/removeEventListener)
*/
external removeEventListener: (
string,
eventType,
eventListener<'event>,
~options: eventListenerOptions=?,
) => unit = "removeEventListener"
Expand Down
15 changes: 15 additions & 0 deletions tests/Global__test.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 15 additions & 0 deletions tests/Global__test.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,18 @@ let response2 = await fetch(
body: BodyInit.fromString(`secret=foo&response=bar`),
},
)

let response3 = await fetch_withRequest(
Request.make2(~input="https://rescript-lang.org/"),
~init={
method: "POST",
headers: HeadersInit.fromDict(
dict{
"Content-Type": "application/x-www-form-urlencoded",
},
),
body: BodyInit.fromString(`secret=foo&response=bar`),
},
)

removeEventListener(Mousedown, MouseEvent.preventDefault, ~options={capture: false})
Loading