Fix signature for Array.splice #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

bloodyowl wants to merge 1 commit into rescript-lang:main from bloodyowl:splice-fix-signature

Contributor

bloodyowl commented Apr 21, 2024

No description provided.


          Fix signature for Array.splice

d192fb6

leoliu commented Feb 25, 2025

Consistency with JS would be nice.

Member

fhammerschmidt commented Feb 25, 2025

Ah I think we tried to return unit for mutating methods, but splice is a bit special since it returns the other half of the array.
@zth WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet