Skip to content

Conversation

fhammerschmidt
Copy link
Member

image

Copy link

cloudflare-workers-and-pages bot commented Sep 9, 2025

Deploying rescript-lang-org with  Cloudflare Pages  Cloudflare Pages

Latest commit: 73f0e14
Status: ✅  Deploy successful!
Preview URL: https://8809f996.rescript-lang.pages.dev
Branch Preview URL: https://playground-toggles-for-jsx-p.rescript-lang.pages.dev

View logs

Copy link
Member

@tsnobip tsnobip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me but for some reason I can't test it in the preview url, it errors with

TypeError: e.setExperimentalFeatures is not a function

@fhammerschmidt
Copy link
Member Author

@tsnobip: I added a check for the playground apiVersion of the compiler bundle to prevent that error. As the playground compiler is only deployed with a new compiler version you'll have to wait until Friday to test this (or check it out locally).

Copy link
Member

@tsnobip tsnobip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok looks good to me now!

@fhammerschmidt fhammerschmidt merged commit 0121332 into master Sep 10, 2025
2 checks passed
@fhammerschmidt fhammerschmidt deleted the playground-toggles-for-jsx-preserve-and-experimental-features branch September 10, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants