Skip to content

Require whitespace before as in to/downto labels #1085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 28, 2025
Merged

Require whitespace before as in to/downto labels #1085

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a28180b
Require whitespace before `as` in `to`/`downto` labels
mediremi Apr 28, 2025
610bc2b
Prefix `RE_TO_DOWNTO_AS_LABELS` patterns with `~` to ensure they only…
mediremi Apr 28, 2025
a7b302a
Add CHANGELOG entry
mediremi Apr 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@

#### :bug: Bug fix

- Fix: incorrect highlighting of `as` inside labelled arguments like `toast` https://github.com/rescript-lang/rescript-vscode/pull/1085

- Fix: bug where incremental analysis does not work when the project folder contains a dot. https://github.com/rescript-lang/rescript-vscode/pull/1080

- Fix: bug where incremental compilation crashes when rewatch is being run in a specific package vs the root of the monorepo. https://github.com/rescript-lang/rescript-vscode/pull/1082
Expand Down
4 changes: 2 additions & 2 deletions grammars/rescript.tmLanguage.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"RE_TO_DOWNTO_AS_LABELS": {
"patterns": [
{
"match": "(to|downto)\\s*(=)",
"match": "~(to|downto)\\s*(=)",
"captures": {
"1": {
"name": "variable"
Expand All @@ -21,7 +21,7 @@
}
},
{
"match": "(to|downto)\\s*(as)",
"match": "~(to|downto)\\s+(as)",
"captures": {
"1": {
"name": "variable"
Expand Down