As part of incremental type checking, when filtering out potentially unwanted parser errors, don't ignore the multiple definitions type error

[mediremi]

When using incremental type checking, if the compiler reports the multiple definitions type error, the user will see a warning notification:

The reason why this happens is as follows:

• incrementalCompilation.compileContents filters out diagnostic messages parsed from the compiler’s stderr that either:
  i) start with Uninterpreted extension 'rescript. or,
  ii) include the source file name

rescript-vscode/server/src/incrementalCompilation.ts

Lines 677 to 687 in 1bf87b3

	.filter((d) => {
	if (
	!d.message.startsWith("Uninterpreted extension 'rescript.") &&
	!d.message.includes(
	`/${INCREMENTAL_FOLDER_NAME}/${entry.file.sourceFileName}`
	)
	) {
	hasIgnoredErrorMessages = true;
	return true;
	}
	return false;

• If all the diagnostic messages extracted from the compiler’s output are filtered out due to matching at least one of the conditions above, then res.length == 0 and hasIgnoredErrorMessages = false
• This then leads to a notification being shown telling the user that something may have gone wrong with incremental type checking
• Unfortunately, the logic for this doesn’t handle one edge case: the multiple definitions type error (Multiple definition of the <kind> name <name>) prints out the LOC of the repeated definition
• By printing out the full LOC, including source file name, this triggers condition number 2 of the filter: !d.message.includes(`/${INCREMENTAL_FOLDER_NAME}/${entry.file.sourceFileName}`)
• Which then triggers the error notification

This PR fixes this issue by adding an exception to the filter for error messages that include the string "Multiple definition of the".

[zth]

Great find, thank you very much!

[nojaf]

Great work on these last PRs @mediremi!

[mediremi]

Thank you!