Skip to content

Don't filter out module-related type errors #1090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 9, 2025
Merged

Don't filter out module-related type errors #1090

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03dd34b
Don't filter out module-related type errors
mediremi May 9, 2025
cd0b464
Add CHANGELOG
mediremi May 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion server/src/incrementalCompilation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -683,7 +683,12 @@ async function compileContents(
) ||
// The `Multiple definition of the <kind> name <name>` type error's
// message includes the filepath with LOC of the duplicate definition
d.message.includes("Multiple definition of the")
d.message.startsWith("Multiple definition of the") ||
// The signature mismatch, with mismatch and ill typed applicative functor
// type errors all include the filepath with LOC
d.message.startsWith("Signature mismatch") ||
d.message.startsWith("In this `with' constraint") ||
d.message.startsWith("This `with' constraint on")
Comment on lines +686 to +691
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of manually baking in these conditions, we could instead check for stderr.trimStart().startsWith("We've found a bug for you") 🤔

)
) {
hasIgnoredErrorMessages = true;
Expand Down
Loading