Show existing compiler warnings and errors on file open#1103
Merged
zth merged 2 commits intorescript-lang:masterfrom Jun 19, 2025
Merged
Show existing compiler warnings and errors on file open#1103zth merged 2 commits intorescript-lang:masterfrom
zth merged 2 commits intorescript-lang:masterfrom
Conversation
mediremi
changed the title
zth
approved these changes
Jun 19, 2025
Member
|
Good catch, I think I've experienced this. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, opening a ReScript file in VS Code does not show existing compiler warnings and errors until a file change triggers
onWorkspaceDidChangeWatchedFiles, which in turn callssendUpdatedDiagnostics.This fix calls
sendUpdatedDiagnosticson file open, ensuring that users will see existing warnings & errors immediately.