Skip to content

Trim quoted paths in bsc args #1121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 28, 2025
Merged

Trim quoted paths in bsc args #1121

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3943db
Trim quoted paths in bsc args
nojaf Aug 28, 2025
b3b7af8
fmt
nojaf Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions server/src/incrementalCompilation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -595,13 +595,18 @@ async function figureOutBscArgs(entry: IncrementallyCompiledFileInfo) {
buildArgs.forEach(([key, value]: Array<string>) => {
if (key === "-I") {
if (isBsb) {
/*build.ninja could have quoted paths on Windows
// On Windows, the value could be wrapped in quotes.
value =
value.startsWith('"') && value.endsWith('"')
? value.substring(1, value.length - 1)
: value;
/*build.ninja could have quoted full paths
Example:
rule mij
command = "C:\Users\moi\Projects\my-project\node_modules\rescript\win32\bsc.exe" -I src -I "C:\Users\moi\Projects\my-project\node_modules\@rescript\core\lib\ocaml" -open RescriptCore -uncurried -bs-package-name rewindow -bs-package-output esmodule:$in_d:.res.mjs -bs-v $g_finger $i
*/
if (isWindows && value.startsWith('"') && value.endsWith('"')) {
callArgs.push("-I", value.substring(1, value.length - 1));
if (isWindows && value.includes(":\\")) {
callArgs.push("-I", value);
} else {
callArgs.push(
"-I",
Expand Down
Loading