Add @rescript/runtime when finding bsc arguments#1125
Merged
nojaf merged 14 commits intorescript-lang:masterfrom Sep 12, 2025
Merged
Add @rescript/runtime when finding bsc arguments#1125nojaf merged 14 commits intorescript-lang:masterfrom
nojaf merged 14 commits intorescript-lang:masterfrom
Conversation
zth
requested changes
Sep 12, 2025
Member
zth
left a comment
zth
left a comment
There was a problem hiding this comment.
Great work! Just 2 wishes for better types, and then a few smaller non-critical questions.
Comment on lines
+135
to
+140
| /** | ||
| * Find all installed @rescript/runtime directories in the given project path. | ||
| * In a perfect world, there should be exactly one. | ||
| * This function is cached per project path. | ||
| */ | ||
| export const findRescriptRuntimesInProject = findRuntimeCached(); |
Member
There was a problem hiding this comment.
Could this live together with the existing project state, or does it need to be on its own here?
Member
Author
There was a problem hiding this comment.
I pulled this out so users can easily run the script and let us know if it finds the runtime.
zth
approved these changes
Sep 12, 2025
Member
zth
left a comment
zth
left a comment
There was a problem hiding this comment.
Great stuff! Let's release this as stable after the next beta release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed solution of rescript-lang/rescript#7858 (comment)
I extracted some code to find the bsc arguments as bsb/ninja and rewatch go there separate way there.