Skip to content

WIP: Emit array spreads using the native es array spread syntax #7034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

WIP: Emit array spreads using the native es array spread syntax #7034

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0c82cb2
emit array spreads using the native es array spread syntax
zth Sep 12, 2024
72b8b8c
changelog
zth Sep 12, 2024
f373aed
add test showing that pipes break
zth Sep 12, 2024
0f63b09
define as primitive
zth Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions jscomp/test/array_spreads.res
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
let x = [1, 2, 3]
let y = [...x, 4, 5, ...x, 6]
let xx = [3]
let x = [1, 2, 3, ...Js.Array2.map(xx, v => v * 2)]
let y = [...x, 4, 5, ...x, 6, ...x->Js.Array2.map(v => v * 2)]
Comment on lines +2 to +3
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Top Js.Array2.map works (no pipe), but bottom does not (using pipes). @cristianoc got any spontaneous ideas about this?

Loading