-
Notifications
You must be signed in to change notification settings - Fork 471
Add some context to the unused variable warning #7050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a06fc64
add some context to the unused variable warning
zth f17de6b
changelog
zth 87ec0df
Update jscomp/build_tests/super_errors/expected/unused_variable.res.e…
zth a1961ea
Update jscomp/ext/warnings.ml
zth afeb9c3
add suggestion to remove unused variable
zth 264a4e8
Merge branch 'master' into unused-variable-error-message-context
zth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 14 additions & 0 deletions
14
jscomp/build_tests/super_errors/expected/unused_variable.res.expected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
|
|
||
| [1;33mWarning number 26[0m | ||
| [36m/.../fixtures/unused_variable.res[0m:[2m2:7[0m | ||
|
|
||
| 1 [2m│[0m let x = { | ||
| [1;33m2[0m [2m│[0m let [1;33mf[0m = 12 | ||
| 3 [2m│[0m 13 | ||
| 4 [2m│[0m } | ||
|
|
||
| unused variable f. | ||
|
|
||
| Fix this by: | ||
| - Prepending the variable name with `_` (like `_f`) to ignore that the variable is unused. | ||
| - Use the variable somewhere. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| let x = { | ||
| let f = 12 | ||
| 13 | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.