Skip to content

Benchmark cleanup #7102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 14, 2024
Merged

Benchmark cleanup #7102

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
822ad9f
Benchmark: reduce alert threshold to 120%
cknitt Oct 13, 2024
9d5fc9d
Remove unneeded permissions
cknitt Oct 13, 2024
48f6d3e
Remove summary-always
cknitt Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,6 @@ on:
pull_request:
branches: [master, 11.0_release]

permissions:
# allow posting comments to pull request
pull-requests: write

concurrency:
group: ci-${{ github.ref }}-1
# Cancel previous builds for pull requests only.
Expand Down Expand Up @@ -346,10 +342,9 @@ jobs:
output-file-path: tests/benchmark-output.json
external-data-json-path: ./tests/benchmark-cache/benchmark-data.json
github-token: ${{ secrets.GITHUB_TOKEN }}
alert-threshold: "150%"
alert-threshold: "120%"
comment-always: true
comment-on-alert: true
summary-always: true

- name: Build playground compiler
if: matrix.build_playground
Expand Down
Loading