Skip to content

Benchmark: report on alert only #7120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Benchmark: report on alert only #7120

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
080b7d2
Only save benchmark data from master builds as new baseline
cknitt Oct 23, 2024
ef118ca
Benchmark: report on alert only (> 5% difference)
cknitt Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,14 +328,14 @@ jobs:
if: matrix.benchmarks
run: ./_build/install/default/bin/syntax_benchmarks | tee tests/benchmark-output.json

- name: Download previous benchmark data
- name: Restore previous benchmark data
if: matrix.benchmarks
uses: actions/cache@v4
uses: actions/cache/restore@v4
with:
path: ./tests/benchmark-cache
key: syntax-benchmark-v1

- name: Store benchmark result
- name: Create new benchmark data and comment on alert
# Do not run for PRs created from other repos as those won't be able to write to the pull request
if: ${{ matrix.benchmarks && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.event.repository.full_name) }}
uses: benchmark-action/github-action-benchmark@v1
Expand All @@ -345,10 +345,17 @@ jobs:
output-file-path: tests/benchmark-output.json
external-data-json-path: ./tests/benchmark-cache/benchmark-data.json
github-token: ${{ secrets.GITHUB_TOKEN }}
alert-threshold: "120%"
comment-always: true
alert-threshold: "105%"
comment-always: false
comment-on-alert: true

- name: Save benchmark data as new baseline
if: matrix.benchmarks && github.ref == 'refs/heads/master'
uses: actions/cache/save@v4
with:
path: ./tests/benchmark-cache
key: syntax-benchmark-v1

- name: Build playground compiler
if: matrix.build_playground
run: |
Expand Down