Skip to content

Conversation

@cknitt
Copy link
Member

@cknitt cknitt commented Dec 13, 2024

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Syntax Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.05.

Benchmark suite Current: 83c2064 Previous: e1b7fb7 Ratio
Print RedBlackTree.res - time/run 2.467595273333333 ms 2.3104395133333333 ms 1.07
Print RedBlackTreeNoComments.res - time/run 2.29476358 ms 2.10057036 ms 1.09
Print HeroGraphic.res - time/run 9.374334339999999 ms 8.775952553333333 ms 1.07

This comment was automatically generated by workflow using github-action-benchmark.

@nojaf
Copy link
Member

nojaf commented Dec 13, 2024

Out of interest, is this also using a newer version of dune?
Or is that unrelated?

@cknitt
Copy link
Member Author

cknitt commented Dec 13, 2024

Out of interest, is this also using a newer version of dune? Or is that unrelated?

Probably, because the version of dune is not locked down in rescript.opam, and because the caches from 5.2.0 will not be used.

@cknitt cknitt merged commit 90df8dc into master Dec 14, 2024
20 checks passed
@cknitt cknitt deleted the 5.2.1 branch December 14, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants