-
Notifications
You must be signed in to change notification settings - Fork 471
Complete tagged template application #7278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 10 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
0f3b8df
WIP tagged template completion
nojaf 6b45ce0
Ensure debug logging is behind flag
nojaf d42587e
Include completions of alias
nojaf 7b013cf
Turn off evenMoreCompletions
nojaf f42e7d7
Add support for tagged template + dot in FrontEnd.
nojaf cb04a89
Revert change to pipe
nojaf 854db1d
Yeah this is the revert pipe thing
nojaf 39a1db5
Revert other changes and commit test result
nojaf e56fa3f
Remove local execution commands
nojaf 9098b74
Remove debug log
nojaf 0ea3bab
Change sample
nojaf 500b9b7
Add changelog entry
nojaf 0d66e05
Merge branch 'master' into complete-tagged-template
nojaf f145cb4
Split up cases in frontend.
nojaf 375dffb
Add example
nojaf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| @module("meh") @taggedTemplate | ||
| external meh: (array<string>, array<string>) => string = "default" | ||
nojaf marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| // let x = meh`foo`. | ||
| // ^com | ||
|
|
||
| // let y = meh`bar`.len | ||
| // ^com | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could add the explicit match (or an if branch using the utils we have for expr holes) just to make the code a bit clearer in what we care about in the AST. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not against having an explicit match, but I don't know what else to return when it is anything else, that is why I went with
| _ -> "".There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that'd remain, you'd just also add the explicit match for clarity, even though it's redundant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I split them after al.
Seems most clear to me.