Skip to content

remove ignore in res_scanner #7280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2025
Merged

remove ignore in res_scanner #7280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,10 @@
- Fix `%external` extension. https://github.com/rescript-lang/rescript/pull/7272
- Fix issue with type environment for unified ops. https://github.com/rescript-lang/rescript/pull/7277

#### :house: Internal

- Remove ignore in res_scanner.ml . https://github.com/rescript-lang/rescript/pull/7280

# 12.0.0-alpha.8

#### :bug: Bug fix
Expand Down
4 changes: 2 additions & 2 deletions compiler/syntax/src/res_scanner.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,13 +257,13 @@ let scan_number scanner =
8)
| _ -> 10
in
ignore (scan_digits scanner ~base);
let _ : bool = scan_digits scanner ~base in

(* *)
let is_float =
if '.' == scanner.ch then (
next scanner;
ignore (scan_digits scanner ~base);
let _ : bool = scan_digits scanner ~base in
true)
else false
in
Expand Down
Loading