Skip to content

@react.componentWithProps with use memo #7300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 21, 2025
Merged

@react.componentWithProps with use memo #7300

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7c0af6e
Exploring problem space
nojaf Feb 17, 2025
65c2bf2
Copy attributes from function
nojaf Feb 17, 2025
91d23dc
Remove moved attributes from expr
nojaf Feb 20, 2025
c416538
Update test
nojaf Feb 21, 2025
1f9c8f1
Add changelog entry
nojaf Feb 21, 2025
10314cb
Merge branch 'master' into componentWithProps-directive
nojaf Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions compiler/syntax/src/jsx_v4.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1185,7 +1185,7 @@ let map_binding ~config ~empty_loc ~pstr_loc ~file_name ~rec_flag binding =
in
(Some props_record_type, binding, new_binding))
else if Jsx_common.has_attr_on_binding Jsx_common.has_attr_with_props binding
then (
then
let modified_binding =
{
binding with
Expand All @@ -1198,8 +1198,6 @@ let map_binding ~config ~empty_loc ~pstr_loc ~file_name ~rec_flag binding =
make_module_name file_name config.nested_modules fn_name
in

Format.printf "Yow %s\n" full_module_name;

let is_async =
Ast_async.dig_async_payload_from_function modified_binding.pvb_expr
in
Expand Down Expand Up @@ -1246,6 +1244,7 @@ let map_binding ~config ~empty_loc ~pstr_loc ~file_name ~rec_flag binding =

let wrapper_expr =
Exp.fun_ ~arity:None Nolabel None props_pattern
~attrs:binding.pvb_expr.pexp_attributes
(Jsx_common.async_component ~async:is_async
(Exp.apply
(Exp.ident
Expand Down Expand Up @@ -1285,7 +1284,7 @@ let map_binding ~config ~empty_loc ~pstr_loc ~file_name ~rec_flag binding =
binding with
pvb_attributes = binding.pvb_attributes |> List.filter other_attrs_pure;
},
new_binding ))
new_binding )
else (None, binding, None)

let transform_structure_item ~config item =
Expand Down
Loading