Add flag for preserve jsx mode to rescript.json #7547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/win32-x64
commit: |
cknitt
reviewed
Jun 18, 2025
| pub fn get_jsx_preserve_args(&self) -> Vec<String> { | ||
| match self.jsx.to_owned() { | ||
| Some(jsx) => match jsx.preserve { | ||
| Some(true) => vec!["-bs-jsx-preserve".to_string()], |
There was a problem hiding this comment.
I think we should not any new options with -bs prefix (and get rid of the old ones eventually).
There was a problem hiding this comment.
This is the BSC flag; it was already in place. Why didn't you speak up when it was introduced?
There was a problem hiding this comment.
Oh, right. Must have overlooked it at that point.
|
@jfrolich just try the pkg-pr version of this PR and the setting is not getting picked up. |
|
I'm a bit confused why the other jsx compiler arguments are currently not passed down. |
Bushuo
approved these changes
Jun 30, 2025
|
Hmm, I guess we can merge and revisit if passing the other jsx args turns out to be a bad thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jfrolich I tried this after building locally,
cargo build --release.Then
../rescript/rewatch/target/release/rewatchin my own project, and this didn't get picked up. Any ideas why?