Skip to content

Update Stdlib_Iterator.resi #7552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 16, 2025
Merged

Update Stdlib_Iterator.resi #7552

merged 2 commits into from
Jun 16, 2025

Conversation

@nojaf
Copy link
Member

@nojaf nojaf commented Jun 16, 2025

No description provided.

tsnobip
tsnobip requested changes Jun 16, 2025
View reviewed changes
Copy link
Member

@tsnobip tsnobip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works locally!
can you also fix the typo (extra parenses) on line 130:

`drop((iterator, n))` returns a new iterator...

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jun 16, 2025 •
edited
Loading

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7552

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7552

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7552

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7552

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7552

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7552

commit: cd5b9f9

@nojaf nojaf requested a review from tsnobip June 16, 2025 13:29
tsnobip
tsnobip approved these changes Jun 16, 2025
View reviewed changes
Copy link
Member

@tsnobip tsnobip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me now!

@nojaf nojaf merged commit 35c8f0e into master Jun 16, 2025
16 checks passed
@zth zth deleted the nojaf-patch-1 branch June 16, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tsnobip tsnobip tsnobip approved these changes

@fhammerschmidt fhammerschmidt fhammerschmidt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nojaf @tsnobip @fhammerschmidt