Rename Belt functions from Exn to OrThrow #7581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mediremi
force-pushed
the
belt-rename-exn-to-or-throw
branch
from
cee08a7 to
0f6d3e1
Compare
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/win32-x64
commit: |
mediremi
force-pushed
the
belt-rename-exn-to-or-throw
branch
2 times, most recently
from
580b381 to
d26812b
Compare
mediremi
force-pushed
the
belt-rename-exn-to-or-throw
branch
from
d26812b to
914560a
Compare
tsnobip
reviewed
Jul 2, 2025
There was a problem hiding this comment.
This looks great, could you also update reanalyze accordingly so it tracks the new functions that throw? It's in https://github.com/rescript-lang/rescript/blob/master/analysis/reanalyze/src/ExnLib.ml
Thanks!
tsnobip
approved these changes
Jul 2, 2025
tsnobip
requested changes
Jul 2, 2025
mediremi
force-pushed
the
belt-rename-exn-to-or-throw
branch
from
299885c to
08e0d8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues the work done in #7518 and #7554 by making the same changes to
Beltmodules.