Docstrings for ArrayBuffer #7594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nojaf
reviewed
Jul 3, 2025
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/win32-x64
commit: |
cknitt
reviewed
Jul 3, 2025
runtime/Stdlib_ArrayBuffer.resi
Outdated
| ArrayBuffer.byteLength(sliced) == 8 | ||
| ``` | ||
| */ | ||
| @send external sliceToEnd: (t, ~start: int) => t = "slice" |
There was a problem hiding this comment.
Just realized: Do we actually need this? Can't we just make ~end optional in slice instead?
Same for Array.sliceToEnd, String.sliceToEnd.
Actually start is also optional according to MDN.
So I think we should have the signature
@send external slice: (t, ~start: int=?, ~end: int=?) => t = "slice"and deprecate sliceToEnd.
There was a problem hiding this comment.
Thanks a lot! Would you also create PRs for Array, String etc.?
cknitt
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also mostly AI written, but again seems good.
#7546