Skip to content

Remove legacy clean #7657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 21, 2025
Merged

Remove legacy clean #7657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2fee062
naive replace
nojaf Jul 16, 2025
7309598
Add root rescript.json
nojaf Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/playground/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
"name": "playground",
"type": "commonjs",
"scripts": {
"clean": "rescript legacy clean",
"clean": "rescript clean",
"test": "node ./playground_test.cjs",
"build": "rescript legacy clean && rescript legacy build && node scripts/generate_cmijs.mjs && rollup -c",
"build": "rescript clean && rescript legacy build && node scripts/generate_cmijs.mjs && rollup -c",
"upload-bundle": "node scripts/upload_bundle.mjs"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/playground/scripts/generate_cmijs.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import {
playgroundPackagesDir,
} from "./common.mjs";

exec("yarn rescript legacy clean");
exec("yarn rescript clean");
exec("yarn rescript legacy");

// We need to build the compiler's builtin modules as a separate cmij.
Expand Down
6 changes: 6 additions & 0 deletions rescript.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"name": "rescript",
"bs-dependencies": [
"@tests/gentype-react-example"
]
}
2 changes: 1 addition & 1 deletion rewatch/testrepo/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,6 @@
"watch": "../target/release/rewatch watch .",
"watch:rescript": "rescript legacy watch",
"clean": "../target/release/rewatch clean .",
"clean:rescript": "rescript legacy clean"
"clean:rescript": "rescript clean"
}
}
2 changes: 1 addition & 1 deletion scripts/res/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"private": true,
"scripts": {
"build": "rescript legacy build",
"clean": "rescript legacy clean",
"clean": "rescript clean",
"dev": "rescript legacy -w",
"apidocs:generate": "yarn build && node GenApiDocs.res.js"
},
Expand Down
2 changes: 1 addition & 1 deletion tests/analysis_tests/tests-generic-jsx-transform/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"private": true,
"scripts": {
"build": "rescript legacy build",
"clean": "rescript legacy clean"
"clean": "rescript clean"
},
"dependencies": {
"rescript": "workspace:^"
Expand Down
2 changes: 1 addition & 1 deletion tests/analysis_tests/tests-incremental-typechecking/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"private": true,
"scripts": {
"build": "rescript legacy build",
"clean": "rescript legacy clean"
"clean": "rescript clean"
},
"dependencies": {
"rescript": "workspace:^"
Expand Down
2 changes: 1 addition & 1 deletion tests/analysis_tests/tests-reanalyze/deadcode/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"private": true,
"scripts": {
"build": "rescript legacy build",
"clean": "rescript legacy clean"
"clean": "rescript clean"
},
"dependencies": {
"@rescript/react": "link:../../../dependencies/rescript-react",
Expand Down
2 changes: 1 addition & 1 deletion tests/analysis_tests/tests-reanalyze/termination/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"private": true,
"scripts": {
"build": "rescript legacy build",
"clean": "rescript legacy clean"
"clean": "rescript clean"
},
"dependencies": {
"rescript": "workspace:^"
Expand Down
2 changes: 1 addition & 1 deletion tests/analysis_tests/tests/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"private": true,
"scripts": {
"build": "rescript legacy build",
"clean": "rescript legacy clean"
"clean": "rescript clean"
},
"dependencies": {
"@rescript/react": "link:../../dependencies/rescript-react",
Expand Down
2 changes: 1 addition & 1 deletion tests/docstring_tests/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"private": true,
"scripts": {
"build": "rescript legacy build",
"clean": "rescript legacy clean",
"clean": "rescript clean",
"dev": "rescript -w"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion tests/gentype_tests/typescript-react-example/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"scripts": {
"start": "rescript legacy build -w",
"build": "rescript legacy build",
"clean": "rescript legacy clean",
"clean": "rescript clean",
"typecheck": "tsc",
"check": "biome check --changed --no-errors-on-unmatched ."
},
Expand Down
2 changes: 1 addition & 1 deletion tests/gentype_tests/typescript-react-example/rescript.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
},
"exportInterfaces": false
},
"name": "sample-typescript-app",
"name": "@tests/gentype-react-example",
"bsc-flags": [],
"jsx": { "version": 4 },
"bs-dependencies": ["@rescript/react"],
Expand Down
2 changes: 1 addition & 1 deletion tests/tools_tests/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"private": true,
"scripts": {
"build": "rescript legacy build",
"clean": "rescript legacy clean",
"clean": "rescript clean",
"dev": "rescript -w"
},
"dependencies": {
Expand Down