Skip to content

Conversation

@hackwaly
Copy link

Allow typed array as argument of set.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jul 21, 2025

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7691

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7691

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7691

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7691

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7691

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7691

commit: 45af478

@nojaf
Copy link
Member

nojaf commented Jul 22, 2025

Hi @hackwaly, thank you for this contribution!
We are in the process of raising the bar a bit for our documentation in StdLib.
Could you add a doc comment with an example as well?

See https://github.com/rescript-lang/rescript/pull/7562/files

The ## Examples will actually be compiled as part of a unit test so we know the binding works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants