Skip to content

Prevent infinite recursion in TypeUtils.resolveTypeForPipeCompletion by not looping over type variables #7731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 30, 2025
Merged

Prevent infinite recursion in TypeUtils.resolveTypeForPipeCompletion by not looping over type variables #7731

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3feb36b
Limit TypeUtils.resolveTypeForPipeCompletion to 10 recursive calls to…
mediremi Jul 28, 2025
6d04269
Merge branch 'master' into fix-code-action-hang
mediremi Jul 28, 2025
6266549
Add CHANGELOG entry
mediremi Jul 28, 2025
971b5ea
Merge branch 'master' into fix-code-action-hang
mediremi Jul 30, 2025
cc9987e
Add comment explaining why TypeUtils.resolveTypeForPipeCompletion enf…
mediremi Jul 30, 2025
44c4030
Prevent infinite recursion in TypeUtils.resolveTypeForPipeCompletion …
mediremi Jul 30, 2025
702a414
Merge branch 'master' into fix-code-action-hang
mediremi Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
#### :bug: Bug fix

- Fix error message that falsely suggested using coercion when it wouldn't work. https://github.com/rescript-lang/rescript/pull/7721
- Fix hang in `rescript-editor-analysis.exe codeAction` that sometimes prevented ReScript files from being saved in VS Code. https://github.com/rescript-lang/rescript/pull/7731
- Fix formatter removes () from functor type. https://github.com/rescript-lang/rescript/pull/7735
- Rewatch: don't compile dev-dependencies of non local dependencies with `--dev`. https://github.com/rescript-lang/rescript/pull/7736

Expand Down
1 change: 1 addition & 0 deletions analysis/src/TypeUtils.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,6 +539,7 @@ let rec resolveTypeForPipeCompletion ~env ~package ~lhsLoc ~full
| _ -> None
in
match typFromLoc with
| Some ({desc = Tvar _} as t) -> (env, t)
| Some typFromLoc ->
typFromLoc |> resolveTypeForPipeCompletion ~lhsLoc ~env ~package ~full
| None ->
Expand Down