-
Notifications
You must be signed in to change notification settings - Fork 471
Fix contents of @rescript/runtime and include it in artifact list #7810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Would you mind dropping a line or two in https://github.com/rescript-lang/rescript/blob/master/CONTRIBUTING.md maybe? Why this exists, when it’s relevant, and which commands to run (and when). |
Yes, I can do that, but the PR does not build yet anyway, will revisit this later. |
@nojaf actually already documented: https://github.com/rescript-lang/rescript/blob/master/CONTRIBUTING.md#adding-new-files-to-the-npm-package Just need to adapt the filename there. |
c4b593f
to
d6db6b3
Compare
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
Would you add ` "keywords": [
"rescript"
] to the runtime's |
@fhammerschmidt We don't have that for the binary packages either though? Let's maybe just merge and do any further improvements later? |
It was in @rescript/std |
The runtime package is also transitive. Anyway, this is not in scope of this PR. |
Artifact list is now a JSON file that can contain the list of file names for multiple packages.