Show Stdlib.Null and Stdlib.Nullable completions for Stdlib.null<'a> and Stdlib.nullable<'a> types, respectively

[mediremi]

Stdlib.res contains these type aliases, but we were not handling them in TypeUtils.completionPathFromMaybeBuiltin, which meant completions did not work for them (see failing test here).

rescript/packages/@rescript/runtime/Stdlib.res

Lines 57 to 59 in 9ce1432

	type null<+'a> = Primitive_js_extern.null<'a>
	type undefined<+'a> = Primitive_js_extern.undefined<'a>
	type nullable<+'a> = Primitive_js_extern.nullable<'a>

[pkg-pr-new]

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7826

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7826

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7826

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7826

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7826

@rescript/runtime

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/runtime@7826

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7826

commit: cd827e3

[zth]

Great stuff! Anything more from that file we need to handle explicitly?

[mediremi]

The other type aliases defined in Stdlib.res are:

• date -> Date.t (autocomplete works ✔️)
• undefined -> Primitive_js_extern.undefined (no Stdlib_Undefined module exists - only Js_Undefined has functions operating on this type)
• lazy_t (deprecated)

So looks like we're handling all the types we should 🎉