Skip to content

Conversation

mediremi
Copy link
Member

The standard library's typed arrays use Stdlib_TypedArray.t but we don't currently show completions for Stdlib.TypedArray.

I've fixed this by adding @editor.completeFrom(Stdlib.TypedArray) to each typed array's type.

@mediremi mediremi marked this pull request as ready for review August 31, 2025 14:56
Copy link

pkg-pr-new bot commented Aug 31, 2025

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7827

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7827

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7827

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7827

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7827

@rescript/runtime

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/runtime@7827

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7827

commit: c622d0c

@zth zth self-requested a review September 1, 2025 18:56
Copy link
Member

@zth zth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@mediremi please feel free to assign people to review so the appropriate people gets notifications etc, and we don't miss PRs.

@mediremi mediremi merged commit a09a3d7 into rescript-lang:master Sep 1, 2025
25 checks passed
@mediremi mediremi deleted the typed-array-completions branch September 1, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants