Better error messages for GADTs and int overflows #7830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zth
requested changes
Sep 2, 2025
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
fhammerschmidt
force-pushed
the
some-error-message-improvements
branch
from
b52a874 to
40f90a7
Compare
mediremi
approved these changes
Sep 2, 2025
tsnobip
approved these changes
Sep 2, 2025
|
Awaiting the build running through and apparently another approvement by @zth then it's good to go. |
cknitt
reviewed
Sep 2, 2025
| @@ -85,7 +85,9 @@ let emit_external_warnings : iterator = | |||
| ( Nonrecursive, | |||
| [{ptype_kind = Ptype_variant ({pcd_res = Some _} :: _)}] ) -> | |||
| Location.raise_errorf ~loc:str_item.pstr_loc | |||
| "GADT has to be recursive types, please try `type rec'" | |||
| "GADTs require recursive type syntax.\n\ | |||
| Please define your type using `type rec` instead of `type`.\n\ | |||
There was a problem hiding this comment.
I think we should avoid saying "please" here, we don't do that in other error messages either.
zth
approved these changes
Sep 3, 2025
There was a problem hiding this comment.
Just saw the int message is for polyvariants, so in the current state none of the suggested fixes are applicable to polyvariants per se (cannot use float nor bigint). I think we can merge anyway since it's better than before. And, there's an issue to add float support to polyvariants, that should at some point be implemented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The int overflow stuff is actually for polyvariants.