Skip to content

Add reset to experimental_features to correctly reset playground #7868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 10, 2025
Merged

Add reset to experimental_features to correctly reset playground #7868

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e4f70b
Add reset to experimental_features to correctly reset playground
fhammerschmidt Sep 9, 2025
eca153f
Changelog
fhammerschmidt Sep 9, 2025
3d46df1
Merge branch 'master' into fix-experimental-features-reset
fhammerschmidt Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,16 @@
#### :bug: Bug fix

- Fix code generation for emojis in polyvars and labels. https://github.com/rescript-lang/rescript/pull/7853
- Add `reset` to `experimental_features` to correctly reset playground. https://github.com/rescript-lang/rescript/pull/7868

#### :memo: Documentation

#### :nail_care: Polish

#### :house: Internal

- Playground: Add config options for experimental features and jsx preserve mode. https://github.com/rescript-lang/rescript/pull/7865

# 12.0.0-beta.10

#### :rocket: New Feature
Expand Down
1 change: 1 addition & 0 deletions compiler/jsoo/jsoo_playground_main.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,6 +378,7 @@ module Compile = struct
(* Responsible for resetting all compiler state as if it were a new instance *)
let reset_compiler () =
warning_infos := [||];
Experimental_features.reset ();
flush_warning_buffer () |> ignore;
Warnings.reset_fatal ();
Env.reset_cache_toplevel ()
Expand Down
2 changes: 2 additions & 0 deletions compiler/ml/experimental_features.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,6 @@ let enable_from_string (s : string) =
| Some f -> enabled_features := FeatureSet.add f !enabled_features
| None -> ()

let reset () = enabled_features := FeatureSet.empty

let is_enabled (f : feature) = FeatureSet.mem f !enabled_features
1 change: 1 addition & 0 deletions compiler/ml/experimental_features.mli
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@ type feature = LetUnwrap
val enable_from_string : string -> unit
val is_enabled : feature -> bool
val to_string : feature -> string
val reset : unit -> unit
Loading