Cache try_package_path #7890
Cache try_package_path #7890
Conversation
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
| Ok(path) => { | ||
| cache.insert(cache_key, Some(path.clone())); | ||
| } | ||
| Err(_) => { | ||
| cache.insert(cache_key, None); |
There was a problem hiding this comment.
[P1] Avoid caching missing packages without invalidation
The new global cache records both successful paths and None for failures. Once a lookup stores None, subsequent calls immediately return the cached error without touching the filesystem. Because the cache is never cleared (reset_try_package_path_cache is unused), running rewatch while node_modules are temporarily incomplete—e.g. before or during an install—causes the tool to keep failing to resolve that package until the process is restarted. Previously, the helper retried on each call and would succeed after installation. Consider either invalidating the cache when dependencies change or skipping negative caching.
Useful? React with 👍 / 👎.
|
Superseded by #7896 |
2 participants
Fixes #7785