Skip to content

Option optimization: do not create redundant local vars #7915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 22, 2025
Merged

Option optimization: do not create redundant local vars #7915

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
eb96936
Option optimization: do not create redundant local vars
cknitt Sep 20, 2025
a564d26
Cleanup
cknitt Sep 22, 2025
f336bda
Comment
cknitt Sep 22, 2025
66d9910
Address review comments
cknitt Sep 22, 2025
61f75df
Don't use Lam_analysis.no_side_effects here
cknitt Sep 22, 2025
cb98fbe
Document refine_let rewrite semantics
cristianoc Sep 22, 2025
418e733
CHANGELOG
cknitt Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions compiler/core/lam_util.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,9 @@ let refine_let ~kind param (arg : Lam.t) (l : Lam.t) : Lam.t =
| Lam_primitive.Pmakeblock _ -> true
| _ -> false
in
(* Helper for spotting RHS expressions that are safe to inline everywhere.
These are the obviously pure shapes where substituting the original value
cannot introduce extra work or side effects. *)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand. "does not have side effects" is enough of a description? If so isn't there a function already.
Otherwise, let's keep it as is.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw some_not_nest could have side effects in the expression inside right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good catch, updated

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh no whitespace changes all over the file, one moment

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok should be fine now

let is_alias_candidate (lam : Lam.t) =
match lam with
| Lvar _ | Lconst _ -> true
Expand Down
Loading