fix: Support Python 3.12 by relaxing numpy version constraint#404
Open
devbyteai wants to merge 1 commit intoresemble-ai:masterfrom
Open
fix: Support Python 3.12 by relaxing numpy version constraint#404devbyteai wants to merge 1 commit intoresemble-ai:masterfrom
devbyteai wants to merge 1 commit intoresemble-ai:masterfrom
Conversation
Relax numpy version constraint from >=1.24.0,<1.26.0 to >=1.24.0,<2.0.0 Enables installation on Python 3.12 and 3.13 Problem ------- Fixes resemble-ai#77, resemble-ai#104, resemble-ai#231, resemble-ai#240, resemble-ai#243, resemble-ai#272, resemble-ai#319, resemble-ai#322, resemble-ai#323, resemble-ai#390 The numpy<1.26.0 constraint prevented installation on Python 3.12+ because numpy 1.24.x/1.25.x cannot be built from source (pkgutil.ImpImporter was removed in Python 3.12, and distutils was removed from stdlib). Solution -------- Changed to >=1.24.0,<2.0.0 to allow prebuilt numpy wheels for Python 3.12/3.13 while maintaining numpy 1.x API compatibility. Test ---- Verified with pip install -e . on Python 3.12 - installs numpy 1.26.4 and imports work correctly.
devbyteai
force-pushed
the
fix/python312-numpy-compatibility
branch
from
765a333 to
68d83fb
Compare
|
Numpy 2.3.5 works fine too, btw. (2.4 doesn't due to |
|
Seeing the upper bound is relaxed to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Relax numpy version constraint from
>=1.24.0,<1.26.0to>=1.24.0,<2.0.0Enables installation on Python 3.12 and 3.13
Problem
Fixes #77, #104, #231, #240, #243, #272, #319, #322, #323, #390
The
numpy<1.26.0constraint prevented installation on Python 3.12+ because numpy 1.24.x/1.25.x cannot be built from source (pkgutil.ImpImporterwas removed in Python 3.12, anddistutilswas removed from stdlib).Solution
Changed to
>=1.24.0,<2.0.0to allow prebuilt numpy wheels for Python 3.12/3.13 while maintaining numpy 1.x API compatibility.Test
Verified with
pip install -e .on Python 3.12: