Fix: Alignment stream analyzer added a new forward hook for each utterance#455
Open
tobmi1 wants to merge 1 commit intoresemble-ai:masterfrom
Open
Fix: Alignment stream analyzer added a new forward hook for each utterance#455tobmi1 wants to merge 1 commit intoresemble-ai:masterfrom
tobmi1 wants to merge 1 commit intoresemble-ai:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new instance of the alignment stream analyzer is currently being instantiated for each call of
T3.inference:chatterbox/src/chatterbox/models/t3/t3.py
Lines 273 to 288 in ed27b95
Hence, each time a new forward hook is added to the backbone's self-attention layers. When generating multiple utterances, this will eventually slow down the generation. After 1000 utterances, the attention masks will be copied 1000 times from GPU to CPU when running on CUDA. This affects the multilingual model since the alignment stream analyzer is enabled by default for it, see, for example, #352.
This PR changes the logic so that the alignment stream analyzer is only instantiated once, and its internal state is instead reset for each utterance without adding new forward hooks to the backbone model.
I tested the fix by generating ~8500 short utterances, which now takes ~4.5h instead of ~50h on my setup.
A big thanks to @benHeid for pointing out the issue in #352! 😊