Skip to content

chore(web): disable the ensure variant matching test #2370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2025

Conversation

gabrielmfern
Copy link
Member

This temporarily skips the test that ensures all variants of our copy-paste component match because the current implementation is very unreliable and hard to maintain. In the future we should:

  1. Infer the inline styles variant from the Tailwind variant somehow which would remove the need to test
  2. Compare the variants by rendering in the browser and comparing getComputedStyle while traversing the entire DOM trees

Firstly doing this because #2361 breaks these tests and we want to release that to users for a more stable experience before actually getting to internal refactors.

@gabrielmfern gabrielmfern requested a review from a team as a code owner July 17, 2025 18:48
@gabrielmfern gabrielmfern requested review from joaopcm and removed request for a team July 17, 2025 18:48
Copy link

changeset-bot bot commented Jul 17, 2025

⚠️ No Changeset found

Latest commit: eccd044

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jul 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-email ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2025 6:56pm
react-email-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2025 6:56pm

@gabrielmfern gabrielmfern force-pushed the chore/temporarily-disable-matching-variants-test branch from de87130 to eccd044 Compare July 17, 2025 18:54
@gabrielmfern gabrielmfern changed the title chore(web): temporarily disable the ensure matching variants for a future refactor chore(web): disable the ensure variant matching test Jul 17, 2025
@gabrielmfern gabrielmfern merged commit e06fb0c into main Jul 17, 2025
13 checks passed
@gabrielmfern gabrielmfern deleted the chore/temporarily-disable-matching-variants-test branch July 17, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants