Skip to content

fix(create-email): correct 'shell' option type in execAsync to resolve TypeScript error in tests #2406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

NithinU2802
Copy link

@NithinU2802 NithinU2802 commented Aug 2, 2025

Pull Request: Fix TypeScript Error in create-email Tests

Fixes: #2385

Summary

This PR resolves a TypeScript compilation error in the create-email package test file (index.spec.ts). The issue occurred due to an incorrect value passed to the shell option in execAsync.

Changes

  • Updated the shell option from true (boolean) to a valid string or removed it as needed to match Node.js type definitions.

Reproduction Steps

  • Run pnpm test on Node.js v22.17.0
  • Error: No overload matches this call. The last overload gave the following error. Type 'boolean' is not assignable to type 'string'.ts(2769)

After Fix

  • pnpm test runs successfully without TypeScript errors.

Environment

  • Node.js Version: v22.17.0

@NithinU2802 NithinU2802 requested a review from a team as a code owner August 2, 2025 17:48
@NithinU2802 NithinU2802 requested review from pedro-stramantinoli and removed request for a team August 2, 2025 17:48
Copy link

changeset-bot bot commented Aug 2, 2025

⚠️ No Changeset found

Latest commit: e76cace

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Aug 2, 2025

@NithinU2802 is attempting to deploy a commit to the resend Team on Vercel.

A member of the Team first needs to authorize it.

@NithinU2802 NithinU2802 closed this Aug 2, 2025
Copy link

pkg-pr-new bot commented Aug 2, 2025

Open in StackBlitz

npm i https://pkg.pr.new/resend/react-email/create-email@2406

commit: e76cace

@NithinU2802 NithinU2802 reopened this Aug 2, 2025
@gabrielmfern gabrielmfern removed the request for review from pedro-stramantinoli August 6, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant